On Tue, Oct 9, 2012 at 1:04 PM, Julien Rioux <[email protected]> wrote: > On Tuesday, 9 October 2012 14:15:04 UTC-4, Aaron Meurer wrote: >> >> I don't understand what you mean here. You always have to use ZZ(2) >> instead of 2 so that you make sure you use the 2 from your ground type. > > > Well, some of the tests don't do this, e.g. > > https://github.com/sympy/sympy/blob/master/sympy/polys/tests/test_factortools.py#L103 > > It looks like tests would past if we change everywhere: > - assert dup_cyclotomic_p([1,1,1], ZZ) == True > + assert dup_cyclotomic_p(ZZ.map([1,1,1]), ZZ) == True
Yes, we should do this, even if we end up deleting the sympy ground types, because it will not be the same with gmpy either (and hence things like benchmarks with gmpy won't be accurate). Aaron Meurer > > -- > Julien > > -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To view this discussion on the web visit > https://groups.google.com/d/msg/sympy/-/4G5u5oaNRnUJ. > > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/sympy?hl=en. -- You received this message because you are subscribed to the Google Groups "sympy" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/sympy?hl=en.
