On Jan 28, 2013, at 8:54 PM, casevh <[email protected]> wrote: Hello,
I maintain GMPY and GMPY2 and I'd like to provide a patch to resolve compatibility issues with GMPY2. The most significant difference is that support for mpq.numerator and mpq.denominator was added in GMPY 1.13 and is available in GMPY2 (and in Python's standard Fraction type). The code in polys uses the old mpq.numer() and mpq.denom() functions that were removed in GMPY2. Would it be acceptable to change the minimum version of GMPY to 1.13 from 1.03? Then the mpq.numer() calls could be changed to mpq.numerator, etc. Absolutely. Gmpy is an optional dependency, so supporting only the latest version is fine. And unlike supporting old versions of Python or IPython, old versions of gmpy are likely to lead to wrong result errors (assumedly). What is the difference between numerator and numer? By the way, I was planning in applying your patch fixing the version check, but I haven't gotten around to it. So if you want to do that as well, go ahead. Aaron Meurer I've resolved most of the other remaining issues but there are a couple that I'm still tracking down. I just want to verify that upgrading the minimum version to 1.13 is acceptable. Regards, casevh -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/sympy?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/sympy?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
