On Fri, Feb 8, 2013 at 5:58 PM, Aaron Meurer <[email protected]> wrote: > On Feb 8, 2013, at 3:01 PM, David Joyner <[email protected]> wrote:
... > > They need to be formatted with underlined headers so that they will be > rendered correctly in Sphinx. See other parts of SymPy for examples. Also > https://github.com/sympy/sympy/wiki/Writing-documentation. Done. (I think.) > > (b) Are there enough examples? > > > Documentation that is not in docstrings should be moved to some rst file in > doc/. Done. > > I think the examples are fine, but you also need tests. This will depend on where it will go, I guess? > > (c) Is the snippet "unique" at the bottom of the file > allowed in SymPy? (I found it somewhere and don't know the copyright > or license. It's a one-liner and thus might not be copyrightable.) > > > I think it's fine. We might even already have something like that if you > search the code base. I think it was in code M Rocklin wrote, but I don't know if it was included or merged into sympy. > > > Other issues? > > > Can you submit this as a pull request? > Can you tell me how or point me to some directions? I have a github account. I posted a first version to http://boxen.math.washington.edu/home/wdj/teaching/crypto1.py Place it in sympy-0.7.1/sympy and all the examples should work. > Aaron Meurer > > > ... > -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/sympy?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
