Test should never fail in a pull request that is not WIP. Yes, you can modify them, if it is ok to change them, due to new functionality. However, it is much more probable that failing tests tell you that something is wrong with your code. For instance:
Adding something to `simplify` that simplifies a very complicated trig expression, but now sin**2+cos**2 does not simplify to 1. This is your error, fix it, do not remove the test, after all this is the idea of tests. Introducing a new class that is needed like IntegrationConstant for the ode solver, but now many tests fail, because they were written without the knowledge of this new class. Fix the tests. On 27 February 2013 14:07, Manoj Kumar <[email protected]> wrote: > Hello, > > Lets say I introduce a new feature and add tests. Suppose I add a new hint > in the ODE module. Due to that , many of the previous tests also fail. Am I > supposed to change every one of them before commiting? > > -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at http://groups.google.com/group/sympy?hl=en. > For more options, visit https://groups.google.com/groups/opt_out. > > -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/sympy?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
