Hi Franz, On Tue, Jul 30, 2013 at 7:55 AM, F. B. <[email protected]> wrote: > The test of code quality already performs a check of no trailing-space and > just 1 new line at the end of the file in sympy's code. > > What about adding more tests? > > The lack of conformance may cause merge problems in old PR. > > What about adding the space requirement in comma separated lists?
While we should use spaces after commas in general, I don't know if we should strictly impose it using a test. I can imagine sometimes breaking this rule for better clarity. > What about a constraint on the number of newlines inside a file? You mean at the end of a file, or overall? I personally like to use more than one newline if I want to visually indent classes / code. Ondrej -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/sympy. For more options, visit https://groups.google.com/groups/opt_out.
