Check out this PR for a discussion of appropriateness of dummification: https://github.com/sympy/sympy/pull/1920
Here's the new PR with the correction: https://github.com/sympy/sympy/pull/2428 On Sun, Sep 1, 2013 at 12:10 PM, Matthew Brett <[email protected]>wrote: > Hi, > > On Sun, Sep 1, 2013 at 12:02 PM, Gilbert Gede <[email protected]> > wrote: > > Looks like in lambdify one of the checks for dummification is broken. > I'll > > open a PR in a minute here. > > > > The dummification was only supposed to happen on numerical translation > > though, so modules='sympy' won't be fixed (or dictionaries). I don't know > > whether lambdify should always dummify or not though. > > I understood from the code and the commit messages that dummification > was only meant for numerical translation, but I wasn't sure why. Can > you explain? > > Even so, if the user passes a dictionary or their own namespace or > there is an implemented function, it seems to me that they are most > likely doing some numerical translation. Do you agree? > > Best, > > Matthew > > -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at http://groups.google.com/group/sympy. > For more options, visit https://groups.google.com/groups/opt_out. > -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/sympy. For more options, visit https://groups.google.com/groups/opt_out.
