That commit just replaced is_irrational = False with is_rational = True. So I think you should dig further in the history.
Aaron Meurer On Thu, Mar 20, 2014 at 8:00 AM, Sergey Kirpichev <[email protected]> wrote: > > On Thursday, March 20, 2014 4:19:24 PM UTC+4, Kalevi Suominen wrote: >> >> This leads to problems if used as a basis for decisions. > > > Sure. Julien, can you comment this? This was introduced by commit 9c359bc > (and this is not tested!). > > In my view, it's wrong. Floats are inexact numbers, we shouldn't mix them > with rational arithmetic. > > -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at http://groups.google.com/group/sympy. > To view this discussion on the web visit > https://groups.google.com/d/msgid/sympy/4710c28b-4aea-42d3-bc4a-33d6366b37fd%40googlegroups.com. > > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/sympy. To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/CAKgW%3D6K%3D3NVAmLdBwN3gh0CVGgNEFp5K2UsjrPpOWHT46AsUXg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
