You should push it to the pull request. We won't merge anything until it works. Code on a pull request is the easiest for us to look at, because GitHub gives a nice diff of everything, and we can comment line-by-line, and Travis runs the tests automatically.
We do have a development workflow https://github.com/sympy/sympy/wiki/development-workflow. Aaron Meurer On Sun, Mar 23, 2014 at 6:03 PM, Peter Petrov <[email protected]> wrote: > Hey everyone, > > I am pretty new here, so I wanted to ask some general questions, before > posting things in the wrong places. > > I am working on resolving an issue, so I wanted to make sure I am doing > things right. I have written some code, but it does not seem to do what I > expect. I have some suspicions why it has bugs, but I need to ask some > questions, since I am not too familiar with sympy as a whole yet. > > Should I update my pull request with the new code and reference it in a post > on the issue discussion page, or do you expect pull requests to be in > general working pieces of code and I > should postpone updating my pull request until I have it all fixed? > > If you have some guidelines outlined somewhere about what you expect from > Pull Requests in general I would appreciate a link. > > Thanks in advance, > > Peter > > -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at http://groups.google.com/group/sympy. > To view this discussion on the web visit > https://groups.google.com/d/msgid/sympy/04668a31-76cf-433d-93ed-6c717efe3e7b%40googlegroups.com. > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/sympy. To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/CAKgW%3D6K5h42wjZyYaw-H4eSQrVF88UCQ4GcWSSHrYsCR%3D3RBeA%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
