Hi Kalevi. Sorry that this discussion got a little derailed with some discussions.
It would be great if you could submit this as a pull request. I think all you need to do is remove Float.is_rational, and then add tests that both Float.is_rational and Float.is_irrational are None (and maybe a brief comment by the tests explaining why). Let us know if you need any help submitting a pull request. We have a guide here too https://github.com/sympy/sympy/wiki/development-workflow. Aaron Meurer On Sat, Mar 22, 2014 at 7:47 AM, Kalevi Suominen <[email protected]> wrote: > > > On Friday, March 21, 2014 10:46:19 PM UTC+2, Aaron Meurer wrote: > >> Actually, that's a good point. Try removing it and see what tests fail. >> >> Aaron Meurer >> >> On Fri, Mar 21, 2014 at 2:55 PM, Kalevi Suominen <[email protected]> >> wrote: >> > It looks like nobody really planned the semantics of Float.is_rational. >> I >> > believe it does not make sense >> > and should be removed from Float's dictionary. If this breaks something >> it >> > should be fixed anyway. >> >> Taking the tests with is_rational removed gave the following results. >> > > ============================= test process starts > ============================== > executable: /usr/bin/python (2.7.3-final-0) [CPython] > architecture: 64-bit > cache: yes > ground types: python > random seed: 576970 > hash randomization: on (PYTHONHASHSEED=1591061748) > > ..... > ________________________________ xpassed tests > _________________________________ > sympy/core/tests/test_args.py: test_as_coeff_add > sympy/core/tests/test_args.py: > test_sympy__matrices__expressions__matexpr__ZeroMatrix > sympy/core/tests/test_wester.py: test_V12 > > tests finished: 5444 passed, 152 skipped, 338 expected to fail, > 3 expected to fail but passed, in 3470.42 seconds > > As far as I can see none of these exceptions has connections with Float. > (see eg. commit 0663271f) > In fact, I was rather expecting that no one would produce useful code > with serious tests of rationality of floats. > > Kalevi Suominen > > -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at http://groups.google.com/group/sympy. > To view this discussion on the web visit > https://groups.google.com/d/msgid/sympy/522f5d2a-6bcd-4ae7-9573-2dfa677d8494%40googlegroups.com<https://groups.google.com/d/msgid/sympy/522f5d2a-6bcd-4ae7-9573-2dfa677d8494%40googlegroups.com?utm_medium=email&utm_source=footer> > . > > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/sympy. To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/CAKgW%3D6K%2BEARNM7jhs%3DS%2B6Gn%3D7n%3DrY7p%3D88bbUqWiaybV8%3Dg_sg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
