On Sun, Oct 19, 2014 at 1:24 AM, Joachim Durchholz <[email protected]> wrote: > Am 18.10.2014 um 07:57 schrieb Aaron Meurer: >> >> Right, all deprecated function calls should be removed from the SymPy >> codebase and test suite. Otherwise we ourselves are not even doing >> what we say we should do. > > > If you build your codebase in the expectation of users writing subclasses, > you need to keep the deprecated function and actually have to point all code > paths towards that deprecated one, so that people who need to override the > functionality both for old and new interface need to do it only once. > > I'm not sure whether SymPy is intended to support subclassing though. It > uses this liberally for its own uses, but that doesn't mean that it's > recommended usage for code that uses SymPy.
It definitely should support subclassing. Sometimes there are antipatterns used that prevent this (like using the class name explicitly instead of self or checking type instead of isinstance), but these should be fixed. See also https://github.com/sympy/sympy/issues/6751. Aaron Meurer > > -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at http://groups.google.com/group/sympy. > To view this discussion on the web visit > https://groups.google.com/d/msgid/sympy/5443592A.6050105%40durchholz.org. > > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/sympy. To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/CAKgW%3D6KeRupDNsj_tneq8k0h8D%2BLu3bF8OVLvMJ1%2BrrciQW%3D%2Bw%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
