On Friday, January 2, 2015 11:39:09 AM UTC+3, Joachim Durchholz wrote:
>
> 2a) Should the rule be applied to continuation lines?
> Typical case as found by me in the codebase:
> a = self.fubar_the_worg(A, x) \
> + make_me_happy(x, y, z)
>
No errors here.
And this other category of continuation lines:
> klaatu = self.barada_nikto(x, y, z,
> a, b, c)
> klaatu = self.barada_nikto(x, y, z,
> a, b, c)
> klaatu = self.barada_nikto(
> x, y, z, a, b, c)
>
FYI: The only error here is the second example.
> 2b) Should the rule be applied to comment lines?
> Typical situations in our code base:
> blah() # Here we need to blah()
> # to avoid frobnication
> blub(a, x, d, w + x + y + z)
> # w2 + x + y + z
>
E116. Please note, that this error is not enabled in my
PR (and also E261 on the first line, that's
disabled too).
If pep8.py can be made to do the tests in the way we want them done,
> should we use it?
>
Sure. SymPy is about symbolic computer algebra, stylistic validators
out of the subject.
4) How do we want to handle external dependencies in general?
> E.g. pep8.py is currently exhibiting a bug that makes it unsuitable for
> our purposes (this is likely to get fixed in the near future).
Just like we handle them now (or do this other projects, whatever). I.e. -
we should
specify version requirements.
> 4a) Should we simply put a copy of the external dependency into SymPy?
>
We already have discussion about this while unbundling mpmath. The end
of it, I think - that this is bad practice in general (though we can have
reasons to do this).
> 4c) Installing dependencies through pip is not a hassle if SymPy itself
> is installable through pip. Right now, SymPy is not prepared for that.
>
What's wrong with this?
$ pip install sympy
Downloading/unpacking sympy
Downloading sympy-0.7.6.tar.gz (6.4Mb): 6.4Mb downloaded
Running setup.py egg_info for package sympy
Installing collected packages: sympy
Running setup.py install for sympy
changing mode of build/scripts-2.7/isympy from 640 to 755
changing mode of /home/sk/.virtualenvs/sympy1/bin/isympy to 755
Successfully installed sympy
Cleaning up...
$ isympy --version
0.7.6
Please do trivial checks for your claims.
> 4d) Should the code that needs the dependency (sympy for mpmath,
> test_code_quality for pep8.py) run pip install?
>
Not in the case of test_code_quality.py. test_*.py - for testing,
not for installation of dependencies.
--
You received this message because you are subscribed to the Google Groups
"sympy" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sympy.
To view this discussion on the web visit
https://groups.google.com/d/msgid/sympy/147a8d4b-44b8-4dc5-9497-87017b2113b5%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
