On Wed, Jan 07, 2015 at 11:38:11AM -0700, Ondřej Čertík wrote: > If the code quality is low, the pull request reviewer should bring > this up in each particular case. We should use 4 spaces for > indentation, but we should allow exceptions and multiline statements > seem like one.
There are real problems, that #8538 was trying to solve. 1) during reviews, stylistic comments sounds like noise for me and I would like to avoid this at all cost. Make all this (or part of) to be subject of the reqular pr testing seems to be a wise idea. Despite the fact that sometimes the tool can blame developers in some questionable cases. 2) Stylistic commits - also is a noise in the git blame. Try to use one on the sympy/core and you can easily hit on some "PEP XYZ" commit during the review of almost every line history. 3) Style validation (i.e. test_code_quality.py) goes out of the project. Other people know this better, lets do symbolic math instead. -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/sympy. To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/20150107200748.GB5210%40darkstar.order.hcn-strela.ru. For more options, visit https://groups.google.com/d/optout.
