One some thinking and some reading of responses, my current thinking is this:

1) This initially looked like a proposal for frivolous formality (nice terminology btw), and I guess that's what ticked off Aaditya and me.
Fortunately that's off the table for good (at least for me).

2) What's still somewhat unclear is the goals. Or maybe I'm missing arguments that link SymPy's project goals to the proposal.

3) Actually I think you're trying to address shortcomings in SymPy's overall organization, at least in part.
I'd like to see what problems you mean to address, for various reasons:
- An experiment without a goal is an experiment where you never know when it's done, or whether it was successful or not, or whether another experiment is require. - It remains unclear what other organisational issues SymPy needs to have addressed. We might be experimenting with a symptom while the real issue is elsewhere (I do have my ideas, probably like most anybody who has an interest in such things; I'm currently halfway through http://producingoss.com/ and can only recommend it, both for it advice and for identifying discussion-worthy aspects in any open source organization - it's one of those texts that are helpful even where one disagrees).

4) If the experiment is done, do not name it "checklist" - that evokes images of a strict list of things to be checked before the commit can go in.
Maybe something like "aspects to look at". Or "review guidelines".

5) What's missing is a list of actual review guidelines.
I think the usefulness of the proposal is in direct proportion to the quality of the guidelines - if the guidelines suck, then having them included in the PR process will suck; if the guidelines draw attention to the important points, they can be immensely helpful.

6) A technicality: I'm not sure how such things can be automatically included in a PR on github. Also, I remember being only vaguely aware of any review guidelines; maybe they should be listed in the contributor's guide.
I may be misremembering stuff though.

I hope this helps.

Regards,
Jo

--
You received this message because you are subscribed to the Google Groups 
"sympy" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sympy.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sympy/5505521F.5030104%40durchholz.org.
For more options, visit https://groups.google.com/d/optout.

Reply via email to