On Monday, March 30, 2015 at 11:26:17 AM UTC+2, Joachim Durchholz wrote:
>
>
> Now in https://github.com/sympy/sympy/pull/9219 , I applied this advice 
> to 
>  >>> from sympy.abc import t, w, x, y, z, n, k, m, p, i 
> and got 
>  >>> t, w, x, y, z, n, k, m, p, i = symbols('t w x y z n k m p i') 
> I think that's actually really dangerous, because it's easy to swap two 
> letters without noticing so you essentially get the equivalent of 
>  >>> p = Symbol('i') 
>  >>> i = Symbol('p') 
> with the devious consequence that everything would still work but any 
> outputs would be utterly confusing because it would print 'p' wherever 
> the user expects 'i' and vice versa. 
>
>
What about a new code quality test checking for such mistakes? 

-- 
You received this message because you are subscribed to the Google Groups 
"sympy" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sympy.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sympy/d3f5521d-c891-4517-9be1-b3e3a979bf48%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to