Am 13.04.2015 um 07:13 schrieb Rathmann:
Just one data point that may be relevant -- blame shows the comment as
dating from 2012.
The code for multiset partitions has changed since then.
Ah thanks, I didn't notice that. Thanks for the pointer.
I'd still like to know what motivated that comment, in particular
whether the "tests break" part of it was "tests break because the
integration gives wrong results" or "tests break because the result is
different, though still correct".
This is going to be cleared up when Tom comes around (he promised to in
private mail, he was just too busy with other stuff to deal with the
issue right away).
Before pull request 1658, by Chris Smith, multiset_partitions gave bad
results. 1658 is from about the same time as the comment.
Later, (pr 1848) I replaced Chris' implementation with a faster algorithm.
The current ordering is deterministic, but I would be surprised if it were
the same as the old algorithm.
Meijer uses quite small sets, two or at most three elements IIRC.
Do you think your changes should have affected the result order given so
small sets?
I don't claim any knowledge of Meijer integration, but I don't remember
breaking any tests there.
Regards,
Jo
--
You received this message because you are subscribed to the Google Groups
"sympy" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sympy.
To view this discussion on the web visit
https://groups.google.com/d/msgid/sympy/552B8024.5080507%40durchholz.org.
For more options, visit https://groups.google.com/d/optout.
