On Tue, Apr 14, 2015 at 3:00 PM, Ondřej Čertík <[email protected]> wrote: > On Tue, Apr 14, 2015 at 1:02 PM, Aaron Meurer <[email protected]> wrote: >> Have you tried git blame -CCC -M? According to the manpage it is >> supposed to be smarter about stuff. There is also the -w flag which >> makes it ignore whitespace (I haven't really tested it, though). In >> general, git blame only gets you to the last change of a line. You >> typically have to checkout the commit before the one given and repeat. >> It would be nice if there were an easier way to do this. > > Indeed, I was wondering if there is some automatic way to track > changes across the code base, so you don't need to manually checkout > the one before commit and repeat.
Some interesting suggestions at http://stackoverflow.com/questions/5098256/git-blame-prior-commits. Aaron Meurer > > Ondrej > >> >> In general, though, I'm not a fan of changing the way we work on code >> just for the sake of git. git is a tool. Smarter tools can exist, like >> a smarter git blame that gets to the real source of something. I've >> always felt that git's pickaxe feature deserves a more usable frontent >> than git blame and git log -S. >> >> I'm much more concerned about how things like pep8 affect people's >> workflow, and especially how the affect new contributors (like if we >> have really strict pep8 rules, then does it raise the barrier to >> entry? Or how does poorly formatted code affect the ability for people >> to read it?). >> >> Aaron Meurer >> >> On Tue, Apr 14, 2015 at 1:03 PM, Jason Moore <[email protected]> wrote: >>> I watched Raymond's talk but didn't come away thinking that we should merge >>> formatting and functionality edits. That seems to cloud the history even >>> more. With git blame you can see the commit message and if it says >>> "formatting", then you need to git blame before that commit to see who >>> actually wrote it. >>> >>> I think the main take away from the talk is just "don't be super strict with >>> pep8". Which he could've said in a much briefer way. >>> >>> BTW, I thought Raymond's talk was really poor. That seemed like an example >>> of an ill prepared talk that dragged on for an hour. I suspect he got the >>> talk spot because he's well known and then didn't really put much effort >>> into it. >>> >>> >>> Jason >>> moorepants.info >>> +01 530-601-9791 >>> >>> On Tue, Apr 14, 2015 at 10:54 AM, James Crist <[email protected]> wrote: >>>> >>>> I expect this to turn into a flamewar, so I'm going to ask everyone to >>>> only give one opinion (voting style). Please please please don't fight >>>> about >>>> this. >>>> >>>> I just got back from PyCon, and there was a presentation there on pep 8 >>>> formatting, and one of the main points was that pure formatting PRs mess up >>>> the history (git blame no longer shows who last made a non-trivial change). >>>> The proposed solution would be to only fix formatting in areas where you're >>>> also making a non-trivial change. >>>> >>>> For example, say I make a tiny bug fix in function foo - I could also >>>> clean up some of the code in foo. That way the last person to touch foo is >>>> not someone who added a space between an operator, but someone who actually >>>> changed the functionality of foo. >>>> >>>> This is not to bash people who do formatting fixes - they are highly >>>> valuable, it's just saying that formatting (IMO) should be done >>>> incrementally as we improve the codebase, not as just formatting PRs. (docs >>>> are an exemption from this, as formatting can be thought of as a functional >>>> change). >>>> >>>> Thoughts??? >>>> >>>> -- >>>> You received this message because you are subscribed to the Google Groups >>>> "sympy" group. >>>> To unsubscribe from this group and stop receiving emails from it, send an >>>> email to [email protected]. >>>> To post to this group, send email to [email protected]. >>>> Visit this group at http://groups.google.com/group/sympy. >>>> To view this discussion on the web visit >>>> https://groups.google.com/d/msgid/sympy/5fe1f28a-9ac0-42db-882a-b8ed0a0f5080%40googlegroups.com. >>>> For more options, visit https://groups.google.com/d/optout. >>> >>> >>> -- >>> You received this message because you are subscribed to the Google Groups >>> "sympy" group. >>> To unsubscribe from this group and stop receiving emails from it, send an >>> email to [email protected]. >>> To post to this group, send email to [email protected]. >>> Visit this group at http://groups.google.com/group/sympy. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/sympy/CAP7f1AgAgvD0u0hq8YjQjnrXX7yaqXPMQNBUOa6zFukbNjM%3D%3Dg%40mail.gmail.com. >>> >>> For more options, visit https://groups.google.com/d/optout. >> >> -- >> You received this message because you are subscribed to the Google Groups >> "sympy" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To post to this group, send email to [email protected]. >> Visit this group at http://groups.google.com/group/sympy. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/sympy/CAKgW%3D6K1Gb_b_GPtsTW-mwpax2%2B%3D9M_k%3Dus0YE_KRVrRMjwhXQ%40mail.gmail.com. >> For more options, visit https://groups.google.com/d/optout. > > -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at http://groups.google.com/group/sympy. > To view this discussion on the web visit > https://groups.google.com/d/msgid/sympy/CADDwiVA%2BVTW3GOryqAUMOd_hvsoNA5t72iKxovovZkXkrN%2BA2g%40mail.gmail.com. > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/sympy. To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/CAKgW%3D6K9hgouDMDPkR5rw0Quu1BwDz00zrHkUOpo3i4y2qrQjQ%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
