FYI: We had a discussion at SymPy on how to synchronize with master and decided that we no longer want to allow or encourage rebasing after a pull request is made to the main SymPy repo.
The main reason is that we stall too many new contributors by forcing them to do too much git kung fu. But there are additional important reasons too: - Once a pull request is "public" the history should not change because other people may have pull it. - Rebasing with merge conflicts is much more difficult - Reviewers are no longer able to see commit by commit changes in a review process. - Github does not manage the diffs in a PR review if a rebase happens. The development docs have been updated: https://github.com/sympy/sympy/wiki/Development-workflow#synchronization-with-master-sympysympy If you want to rebase then you should do it before you make a pull request, either locally or on your fork's branch. Jason moorepants.info +01 530-601-9791 -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/sympy. To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/CAP7f1AjGGrvdUSA6VmdpgpBPyGRCO89x38WrpYDn4bJK74NNZg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
