On Wed, Sep 23, 2015 at 5:59 PM, Ondřej Čertík <[email protected]> wrote: > On Wed, Sep 23, 2015 at 2:12 PM, Aaron Meurer <[email protected]> wrote: >> I've enabled branch protection for master on sympy/sympy. I still >> recommend removing write access to origin as described at >> https://github.com/sympy/sympy/wiki/Pushing-patches as pushing to >> master directly is still allowed (you just can't force push). > > So the worst that can happen now is that somebody with push access > pushes some patches into master that we don't want. And the fix is > then just disabling the protection, resetting the master and > re-enabling the branch protection again. That's an improvement. > > Even better would be if github disallows any pushes to master, but > even the current solution is not bad.
You can do that too, but it is tied to Travis CI, so that you can't merge anything to master unless the Travis tests pass. Actually, it looks like you can choose which status checks are required, so maybe not requiring any will amount to this. I'm going to try this (https://github.com/sympy/sympy/settings/branches/master). If you find you can't merge branches that you should be able to, please let me know so I can revert it. By the way, I also enabled branch protection for all the other SymPy repos. Hopefully this won't break any of our bots that push to various gh-pages branches. Aaron Meurer > > Thanks Aaron. > > Ondrej > > -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at http://groups.google.com/group/sympy. > To view this discussion on the web visit > https://groups.google.com/d/msgid/sympy/CADDwiVBA6yDA1ko5oXchVyjrHYZ_6dgu5ByiyK7Gtsi-TPzJiw%40mail.gmail.com. > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/sympy. To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/CAKgW%3D6KCP9TVP4Jo_7rr4J2mVnQ6Hjubddw9O1YWuwaJbYMNVQ%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
