The big concern is that we shouldn't ever trigger a KeyError. I suspect the new lru_cache in 3.5 was not supposed to change this behavior but was simply supposed to be more performant than the 3.4 version
On Thu, Oct 1, 2015 at 8:45 PM, Kate MacInnis <[email protected]> wrote: > I don't have any previous experience with caching (and I don't have tons > of time to spend on this), so I'm of no help with debugging lru_cache, but > this change fixes all the broken cache-related tests. > <https://github.com/sympy/sympy/commit/88e0da46da7cef491ffbb10116a1f8c8732abe83> > Are there any problems caused by catching KeyError here? > > -- > You received this message because you are subscribed to a topic in the > Google Groups "sympy" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/sympy/AnwYTJGRBB4/unsubscribe. > To unsubscribe from this group and all its topics, send an email to > [email protected]. > To post to this group, send email to [email protected]. > Visit this group at http://groups.google.com/group/sympy. > To view this discussion on the web visit > https://groups.google.com/d/msgid/sympy/f7eb4e48-048b-4d74-b0c3-78a9c6ef91ee%40googlegroups.com > <https://groups.google.com/d/msgid/sympy/f7eb4e48-048b-4d74-b0c3-78a9c6ef91ee%40googlegroups.com?utm_medium=email&utm_source=footer> > . > > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/sympy. To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/CALoNiQfPSZxm%3D3kPn7JMQiRU%2BUnHAYunget1HXoSbX0C6yY2yA%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
