Justin, We like to see "atomic" PRs that are shorter rather than longer so that they are easy to review. Most super long PRs take forever to review and get merged, so send in smaller updates in general. And the atomic portion means that you pick one complete thing to add per PR which generally includes the addition, unit tests, and doc changes. You can also submit PRs early in your writing stage and make their title start with "[WIP]" to indicate it is a work in progress and you want feedback as you go along.
Jason Jason moorepants.info +01 530-601-9791 On Thu, Oct 22, 2015 at 2:16 PM, Justin <[email protected]> wrote: > On Wednesday, 21 October 2015 17:37:31 UTC+2, Jason Moore wrote: >>> >>> I will help you get your dev environment setup and give info on how to >>> make PRs, etc. >>> >>> > Hey Jason, I have my dev environment set up per the development workflow > wiki. I would like some information on how and when to make the pull > requests... vectors are a deep subject and when I feel what I coded is > ready, surely something will be missing. > > Also, if there are any more wiki's you feel I should look at, let me know. > > >> I'd recommand using PyCharm, it has excellent Python code analysis, >> debugger and github integration. >> >> https://www.jetbrains.com/pycharm/download/ >> >> Community Edition is free and open source. >> > > I actually googled that when reviewing your PR! Awesome IDE!! Been using > Eclipse for a while when break points are useful and I hated it the whole > time. > > -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at http://groups.google.com/group/sympy. > To view this discussion on the web visit > https://groups.google.com/d/msgid/sympy/af67bd50-bf8f-49d8-8b3a-bb3d4109c4aa%40googlegroups.com > <https://groups.google.com/d/msgid/sympy/af67bd50-bf8f-49d8-8b3a-bb3d4109c4aa%40googlegroups.com?utm_medium=email&utm_source=footer> > . > > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/sympy. To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/CAP7f1Ah%2BEB%2B45ezT5HL6T%2B8LGfcqRyEZTe0DFuB-w7H64SiYcA%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
