Hi Thomas, On Sun, Dec 6, 2015 at 3:13 PM, Mateusz Paprocki <[email protected]> wrote: > Hi, > > On 6 December 2015 at 16:46, Thomas Baruchel <[email protected]> wrote: >> I did three Pull requests 10/14 days ago: >> https://github.com/sympy/sympy/pulls/baruchel >> Since that, I have no news; maybe it is normal, but I am asking in case I >> would have forgotten something? >> Do I need to do something more? Regards. > > pull request should be sufficient. However, we have very limited > resources, so it may take awhile for us to get to review your > contributions. What you could do is to advertise your work a little > bit, by figuring out who maintains or has solid contributions to a > module and politely pinging him/them in a PR. This way you could have > got my attention on #10171 a bit earlier. Otherwise, a new PR will > easily sink in a busy inbox. It also doesn't hurt to have some > discussion on the mailing list about what you work on prior to > submitting a PR. Also, you rise your odds for a review when all the > basic prerequisites are in the PR upon submission, including tests, > docstrings/doctests, references, proper code style, etc. (no worries > here, at least #10171 is solid).
You can also mention people on github (e.g. @certik for myself), that way they will get an email in their inbox. The best is to find people that are relevant to the code you are changing. But if nobody is reviewing your PRs, feel free to ping me as well, I'll be happy to help. Ondrej -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/sympy. To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/CADDwiVC_Ldg4wj-W7cMLow1iXx8n0UUxKBLB-jf433pZa8XztA%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
