It will make reviewing easier, because if someone doesn't respond to a review I can just push the fix. That's assuming they checked the box (it's off by default).
It doesn't help with finding which PRs to review, which is what my other discussion is about. Maybe it would be useful to be able to see at a glance which pull requests I can push fixes to. Aaron Meurer On Wed, Sep 7, 2016 at 4:05 PM, Samuel Lelièvre <[email protected]> wrote: > > 2016-09-07 21:01:53 UTC+2, Aaron Meurer: >> >> GitHub now has a checkbox that you can check on your PRs, which lets you >> grant project maintainers access to push to that branch. See >> https://github.com/blog/2247-improving-collaboration-with-forks. So now, >> if someone has checked that box, instead of waiting for them to fix issues >> from your review, you can just push changes to their branch directly. >> >> Aaron Meurer >> > > Does this help with your "idea for PR reviewing"? > https://groups.google.com/d/topic/sympy/KJwDwT_P6Lw/discussion > > -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at https://groups.google.com/group/sympy. > To view this discussion on the web visit https://groups.google.com/d/ > msgid/sympy/cf74b8ff-5f99-4f6f-840a-e1e76ca233d6%40googlegroups.com > <https://groups.google.com/d/msgid/sympy/cf74b8ff-5f99-4f6f-840a-e1e76ca233d6%40googlegroups.com?utm_medium=email&utm_source=footer> > . > > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/sympy. To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/CAKgW%3D6LBkitJYHJuPE17so6-JX_f630v4BruC-E9ABOVJGbZOg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
