It think the result should be a dictionary with keys being the vertices and the value being the Ray defining the bisector with one point being the vertex. I think that the Triangle implementation should do the same -- it is not necessary to make the result a segment terminating on the side opposite of the vertex (which is an unnecessary addition calculation). An alternative would be to return a Line but it is easy enough to turn a Ray into a Line with `Line(ray)`. The issue you cite gave a suggestion of what to use as the 2nd point of the Ray. I wonder if it might be better to use a point located a distance from the vertex that is equal to the length of the shorter of the two sides that define the angle at the vertex. This has the merit of scaling the Rays in relationship to the vertices from which they emanate.
On Monday, October 2, 2017 at 7:05:12 PM UTC-5, EKW wrote: > * which returns a dictionary from vertices to segments with segments from > the vertex to the incenter > > On Monday, October 2, 2017 at 5:02:01 PM UTC-7, Ethan Ward wrote: >> >> There was a request for this feature (12599 >> <https://github.com/sympy/sympy/issues/12599>). What object should a >> bisector be? There is an implementation for triangles already, which >> returns a from vertices to segments from the vertex to the incentere. Would >> it make sense to just use lines, or rays? What points should be used to >> define the object, whether it is lines, rays or segments, for a general >> polygon? >> > -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/sympy. To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/67028509-c42f-4160-99e3-f4bc7f1a70ec%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
