Upon closer inspection I see that there *IS* a highlighting of the closing text. This confirms, too, that the following are valid close sequences (and the detected closing word is underlined with a dotted line):
fixes #12345 fixes: #12345 This PR fixes #12345 This PR does not fix #12345 (oops! fix is followed by an issue number so the issue will be closed) The following do NOT close #12345 and the fixes- #12345 (intervening '-' makes it invalid) fixes #1, #12345 (closes #1 but not #12345) fixes 12345 (no # before the 12345) This PR does not fixx #12345 On Monday, December 11, 2017 at 7:00:34 PM UTC-6, Aaron Meurer wrote: > > GitHub already does something like this (without the link) for > duplicate issue. See for instance > https://github.com/sympy/sympy/issues/13556#issuecomment-341198018. > > Aaron Meurer > > On Mon, Dec 11, 2017 at 7:55 PM, Chris Smith <[email protected] > <javascript:>> wrote: > > Something that would be a nice addition to github is an autolink for any > > autoclosing syntax. For example if I say "I don't think this will fix > #123" > > the word "fix" would become a link (just as the #123 becomes a link) but > the > > "fix-link" would link to a page that says, > > ``` > > Using an autoclosing keyword before an issue or PR number will cause > that > > issue/PR to be closed when this PR is merged. If this is not your > intent, > > insert the word "issue" before the issue number. See > > [here](https://help.github.com/articles/closing-issues-using-keywords/) > for > > more details. > > ``` > > Does anyone else see merit in this? > > > > /c > > > > -- > > You received this message because you are subscribed to the Google > Groups > > "sympy" group. > > To unsubscribe from this group and stop receiving emails from it, send > an > > email to [email protected] <javascript:>. > > To post to this group, send email to [email protected] > <javascript:>. > > Visit this group at https://groups.google.com/group/sympy. > > To view this discussion on the web visit > > > https://groups.google.com/d/msgid/sympy/e12820d4-e739-49ee-af96-7e6f2f4b5eb0%40googlegroups.com. > > > > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/sympy. To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/5802abda-3d94-4373-9cd3-f828affa0ec5%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
