Thank you very mach for the help! I installed the packages and i will test the coverage locally for now on. I hope everything else is ok.
Τη Πέμπτη, 19 Μαρτίου 2020 - 4:26:17 μ.μ. UTC+2, ο χρήστης Oscar έγραψε: > > Oh of course in your example you are added tests so your diff is only > in the testing code and coverage is not measured there. In that case > you should only look through codecov to see the coverage reported for > the files you were trying to increase the coverage of. > > I have found that it is better to do coverage testing locally when > trying to increase coverage because the codecov coverage analysis does > not always update when you push changes to a PR. I would do coverage > testing like (pip install pytest, coverage and pytest-cov): > > $ pytest sympy/algebras/ --cov=sympy.algebras.quaternion > --cov-report=html > > Then open htmlcov/index.html in the browser. > > I just did that and the coverage seems to be 99% already. > > On Thu, 19 Mar 2020 at 13:27, Basilis Kalos <[email protected] > <javascript:>> wrote: > > > > Thank you very much for the help! > > The diff coverage in my report is n/a. From what i understand, the > files that i changed are un-tracked and that's causing the problem. Can i > fix that or should i redo the commit? > > Thank you! > > > > Τη Πέμπτη, 19 Μαρτίου 2020 - 2:04:28 μ.μ. UTC+2, ο χρήστης Oscar έγραψε: > >> > >> That's fine don't worry about it. The meaningful part of the codecov > >> report is the diff coverage so check that. > >> > >> The coverage of the whole codebase varies from run to run due to > >> non-determinism in e.g. set ordering and also randomised testing that > >> takes place in some parts of the test suite. > >> > >> On Thu, 19 Mar 2020 at 12:02, Basilis Kalos <[email protected]> > wrote: > >> > > >> > Hi all! > >> > Four days ago i made a pr with two tests for the Quartanion file to > increase its coverage. From the Codecov report tho came that the coverage > will decrease by 0.019%. Looking in to it, i saw that Codecov reported > decrease in coverage for modules i have made no changes at all. In the > Codecov site it said that this can happen and to review the report but i > didn't find a way to actually fix this. Is there anything i can do? Should > i close the pr and re-send it? > >> > > >> > -- > >> > You received this message because you are subscribed to the Google > Groups "sympy" group. > >> > To unsubscribe from this group and stop receiving emails from it, > send an email to [email protected]. > >> > To view this discussion on the web visit > https://groups.google.com/d/msgid/sympy/8c0ded96-d710-4e19-bd75-96d674abda14%40googlegroups.com. > > > > > > -- > > You received this message because you are subscribed to the Google > Groups "sympy" group. > > To unsubscribe from this group and stop receiving emails from it, send > an email to [email protected] <javascript:>. > > To view this discussion on the web visit > https://groups.google.com/d/msgid/sympy/ca77d0f8-9f6f-4801-8a2c-3f8875d10fb2%40googlegroups.com. > > > -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/3427b144-d38c-425c-8e74-1c14a5e7fa52%40googlegroups.com.
