I looked through the proposal and have some suggestions. Can you provide comment access to the people with the link? I think it'd be better to comment directly on the proposal. As for your queries: 1) I will be mentoring for the project. 2) No, you do not need to provide more details in the Milestone overviews, but you can use something like implement variable declarations instead of transform_variable_declaration() . I think a little more can be done each month than what is currently proposed.
If you are familiar with C and C++ and its syntax, and seeing you have a few PRs improving the current parsers, you are familiar with the current parsers, Can you also improve the current C parser during this GSoC period, like implementing loops and other stuff which are not currently implemented in the C parser, but you are proposing for the Java parser? Regards, Nikhil Maan On Monday, March 23, 2020 at 4:07:32 AM UTC+5:30, Gajjar Smit wrote: > > Here is the docs link to my GSoC Proposal: > https://docs.google.com/document/d/1HFWvBV-NjQVd2Tvv4-_tlNrGG52WWxJUlUlByLxfOog/edit?usp=sharing > > Please go through it. Any form of suggestions are most welcome! > > Few queries: > > 1. Who will be the potential mentor if this project gets selected? > 2. Do let me know if "Overview of Milestones" part after each phase, > showing high level implementation of code should have more details or is > it > sufficient! > > Thanks > On Tuesday, 17 March 2020 01:00:44 UTC+5:30, Gajjar Smit wrote: >> >> I will surely look into the commonalities in those modules if they exist >> and will raise relevant issue! >> >> On Tue 17 Mar, 2020, 12:46 AM Aaron Meurer, <[email protected] >> <javascript:>> wrote: >> >>> Another thing to consider, since this would be the third such language >>> to be supported in SymPy (after C and Fortran), is if there are >>> commonalities in the parsing code for each that should be factored out >>> into a helper submodule. >>> >>> Aaron Meurer >>> >>> On Mon, Mar 16, 2020 at 1:12 PM Gajjar Smit <[email protected] >>> <javascript:>> wrote: >>> > >>> > Thanks Aaron and Nikhil for suggestions. >>> > >>> > I have gone through javalang package and tried out few examples. AST >>> nodes can be traversed in javalang and children can be accessed. Here, >>> every relevant bunch of tokens are represented as an object of superclass >>> CompilationUnit(somewhat similar to TranslationUnit in clang) which is >>> again a subclass of generalized Node class. (Link to the javalang repo) >>> > A basic example of tree traversal is attached as image. >>> > >>> > >>> > I went through AST hierarchy in sympy ast module. I am also trying to >>> understand generic sympy_expr module. >>> > Should I start working on my proposal in this direction? >>> > >>> > -- >>> > You received this message because you are subscribed to the Google >>> Groups "sympy" group. >>> > To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected] <javascript:>. >>> > To view this discussion on the web visit >>> https://groups.google.com/d/msgid/sympy/f3d1221b-e731-49e0-9c01-09671f7fbb02%40googlegroups.com >>> . >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "sympy" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected] <javascript:>. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/sympy/CAKgW%3D6%2Bh2H33AehhfmsPgFBD0fkz7-X4cTEx4tOy3w4N2XUuPA%40mail.gmail.com >>> . >>> >> -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/d3eefb38-7af2-45d1-ad3f-1c4d11be805f%40googlegroups.com.
