On Thu, Apr 1, 2021 at 4:44 PM JSS95 <jeesoo9...@snu.ac.kr> wrote:
>
> One thing I'm concerned with is import issue. If we make ask(Q.positive(x))
> and x.is_positive do the same thing
> and use the former inside the evaluation methods, ask() and Q will be
> imported in core module. My idea to avoid
> this was to pass getter function instead of assumptions, but there may be a
> better way.
I'm not sure I follow why this is a huge concern. Is it a question of
avoiding circular imports? Anyway, if the two systems are merged, then
ask() and Q would only be needed for cases where the query can't be
represented using the old assumptions. The simpler is_predicate or
Symbol('x', predicate=True) syntax is much easier to type for the
cases where it can represent what you want to do.
>
> AssumptionWrapper seems good to me, and if it gets more approval I am willing
> to make a prototype PR to discuss
> the detailed design.
I hadn't noticed this in your original email. I agree we can
experiment with it. It does seem like an interesting idea, and it
doesn't modify any existing core or assumptions code, so there's no
cost to playing with it and seeing if it works.
Aaron Meurer
>
> Jisoo
>
> --
> You received this message because you are subscribed to the Google Groups
> "sympy" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to sympy+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/sympy/60b55bc5-f45a-407d-a6dc-3afb59646a87n%40googlegroups.com.
--
You received this message because you are subscribed to the Google Groups
"sympy" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to sympy+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/sympy/CAKgW%3D6JSCj3wYHM%2B-FGavYcp1OXj6-ymYtPRt2VK%2BBMPYS03MQ%40mail.gmail.com.
