Thank you for the response and help Sir Oscar Benjamin and Sir Aaron Meurer I used the command mailmap_check.py and my name was there in the .mailmap but my github user name and email was recorded in the format [email protected] therefore, I added the line in .mailmap as mentioned in the format *Joe Bloggs <[email protected] <[email protected]>> joeb <[email protected] <1785690389%[email protected]>>* and then I used the following commands --> $ git add .mailmap --> $ git commit -m 'author: add Kuldeep to .mailmap' As you said ''What is potentially a problem is if your PR was created before the mailmap_check.py script was added. In that case you'll need to merge or rebase with master first.'' And unfortunately that was the problem, then I tried to rebase with master, I tried again and again but it was too problematic for me ; ) Then I just closed that PR and deleted the branch then, I started again with a new branch and made the PR but it showed the changes of the .mailmap file too and then again the author's check failed again. I guess I am missing some step or I made some mistake though. Please Help!
On Mon, 31 Jan 2022 at 07:14, Oscar Benjamin <[email protected]> wrote: > On Mon, 31 Jan 2022 at 01:13, Aaron Meurer <[email protected]> wrote: > > > > > > > > On Sun, Jan 30, 2022 at 11:48 AM Oscar Benjamin < > [email protected]> wrote: > >> > >> On Sun, 30 Jan 2022 at 15:26, 36 AI Kuldeep Borkar > >> <[email protected]> wrote: > >> > > >> > Thank you for your mail Sir Oscar Benjamin, > >> > As a new contributor I was having difficulty after making a pull > request authors check failed but then after observing the details I have > done these things > >> > > >> > --> Before editing .mailmap, I run the command bin/mailmap_update.py > >> > --> then made entry to .mailmap as > >> > Name <global git email> > >> > --> then re-run bin/mailmap_update.py > >> > --> run bin/authors_update.py > >> > --> git commit -am 'Update .mailmap/AUTHORS. Welcome to Sympy!' > >> > > >> > Are these things correct? > >> > And will that check pass afterwards or I will have to make the pull > request again? > >> > >> No, you should be using mailmap_check.py as described here: > >> > https://github.com/sympy/sympy/wiki/Development-workflow#add-your-name-and-email-address-to-the-mailmap-file > >> > >> Don't use the mailmap_update.py script: that's the old script that > >> shouldn't be used any more. > > > > > > I think I mentioned this on the PR, but we should delete those other > scripts so they don't confuse people. Or if they are still used by the > release scripts they should be moved into the release folder. > > Yes, we should delete them. We're still in a confusing situation right > now though where different people have different files. If we did > delete the old files then it's likely that Kuldeep would still see > them on this branch. Until the branch is updated it will still show > the old files and not the new. I think a lot of the confusion comes > from that. > > -- > Oscar > > -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/sympy/CAHVvXxTXNQqOnHztOTrJZ9NBfzU3TPiEG5YDbzS%2BNY80Kpko7g%40mail.gmail.com > . > -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/CAEBjiXcWEe8QpVDhyoTDZchcee4HxwhAtqm07GghLWEUfWKXdw%40mail.gmail.com.
