On Tue, Apr 12, 2022 at 4:56 PM Orestis Vaggelis <[email protected]> wrote: > > The Group class would contain all the currently implemented classes as its > subclasses. Right now, some methods are being reused both in FpGroup and the > PermutationGroup class (for example the is_nilpotent() and is_abelian()). By > creating a more general Group class we could avoid that and make the code > more concrete.
Would there actually be any commonality between the implementations? I'm not really an expert on the group theory module, so I'm not sure. Otherwise, what would Group be other than just a bunch of empty method stubs? Aaron Meurer > > > On Tuesday, 12 April 2022 at 23:04:17 UTC+3 [email protected] wrote: >> >> Can you be more specific about what you mean by messy, and what your >> suggested class would contain? There is already a PermutationGroup >> class that represents a group generated by a set of permutations. >> >> Aaron Meurer >> >> On Tue, Apr 12, 2022 at 11:01 AM Orestis Vaggelis >> <[email protected]> wrote: >> > >> > Hello, my name is Orestis Vaggelis and I'm a senior undergraduate >> > mathematics student in Greece. I noticed that the code related to >> > group-theoretic methods is a bit messy. Therefore I'm thinking if creating >> > a Group class containing all the related methods and subclasses would be >> > beneficial. >> > >> > I am more than happy to hear your thoughts about this! >> > >> > -- >> > You received this message because you are subscribed to the Google Groups >> > "sympy" group. >> > To unsubscribe from this group and stop receiving emails from it, send an >> > email to [email protected]. >> > To view this discussion on the web visit >> > https://groups.google.com/d/msgid/sympy/5dac6985-8a44-4507-9d86-f152da9ce660n%40googlegroups.com. > > -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/sympy/5976f553-ea91-4224-932f-350664ea8cf9n%40googlegroups.com. -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/CAKgW%3D6LNUfq6o3Cor%3Dsy6m4bF8cTtDDGsZ_3MbLsU0OFqNuroQ%40mail.gmail.com.
