I was going through old issues and I found two issues in integrals that need to be closed because it was already solved.
These are the links to related issues that needs to be closed. https://github.com/sympy/sympy/issues/5212 https://github.com/sympy/sympy/issues/4258 Please let me know if I should write tests for these issues. On Wed, 7 Feb 2024, 10:50 pm Shishir Kushwaha, < [email protected]> wrote: > There are a few open issues where the solution to the problem of the > author has been provided by a contributor or a member , those solutions > maybe helpful to others in the future , so do they need to remain open or > we make a comment to close them . Do you think it would be better if we > added those solutions to a file like a guide ? > On Tuesday 6 February 2024 at 17:43:22 UTC+5:30 Oscar wrote: > >> On Tue, 6 Feb 2024 at 07:42, Shishir Kushwaha >> <[email protected]> wrote: >> > >> > I was going over the open issues i could potentially solve and I think >> some of them are still open after their solution PR has been merged. What >> do I do about those issues . Should I leave a comment on the issue on its >> closing or ask what needs to be done ? >> >> Sometimes an issue that should have been closed gets forgotten when a >> PR is merged. Also sometimes there are several PRs for the same issue >> and once one is merged the others should be closed but this can also >> be missed. In either case it is useful to comment on the issue or PR >> pointing out that it could be closed. >> >> Please include information showing how to demonstrate that the problem >> is fixed and mention that the PR that was merged has a test for the >> issue or point to where the issue is tested in the codebase. Basically >> include enough information that it is easy for someone else to read >> your comment and then confirm that it should be closed. >> >> -- >> Oscar >> > -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/sympy/d3f66066-8741-4825-913b-0deba2168061n%40googlegroups.com > <https://groups.google.com/d/msgid/sympy/d3f66066-8741-4825-913b-0deba2168061n%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/CAHZvv1b1JCAe1rJTqfD4VKm3qpZF7hTr3j0FvROzcFf0c2A2ng%40mail.gmail.com.
