You don't need to worry about those errors. They are not related to the changes in your PR and any PR can be merged even if those tests fail. It looks like those same errors are showing on all PRs right now.
The errors that you see are in the numpy nightly test job. This is a job that runs the sympy tests with both numpy and scipy installed from their nightly wheel build. I added these tests because the upcoming release of numpy 2.0 is likely to break some things that sympy depends on. The jobs are currently failing most likely because of a change in numpy or scipy rather than any change in sympy. I just tried installing the nightly builds locally and running the matrices tests and I see one failure in test_issue_14943: > assert array(M, dtype=float).dtype.name == 'float64' E TypeError: MatrixBase.__array__() got an unexpected keyword argument 'copy' It looks like numpy now passes copy= when calling __array__ but sympy's Matrix.__array__ method does not expect the copy argument. My guess is that this is coming from here: https://github.com/numpy/numpy/pull/25168 There is already a numpy issue about this: https://github.com/numpy/numpy/issues/25916 That error is still not the segfault seen in CI though... On Sun, 3 Mar 2024 at 11:09, Spiros Ts <[email protected]> wrote: > > Author: Spiros Tsioupros > Github: https://github.com/Spiros7bit > email: [email protected] > > Hello community, I made a pull request to add some links to README.md. While > 63/68 checks are passed, 5 errors about test and test_optional_dependencies > are thrown. I had read in the Development Workflow Process that we should > write tests when making pull requests for code changes. > > My question is: Do we have to write a test when we make changes to README.md > or is the problem elsewhere? > > pull request link is here. > > Yours sincerely. > > -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/sympy/0d348c35-8350-4f7c-a787-89d7ac7ea89fn%40googlegroups.com. -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/CAHVvXxRMwf8eyiCKJ7jCdXVqv64zNzj_7g%3D8Ha_FEaOm9YgwHg%40mail.gmail.com.
