Hi there, may I ask why exactly 1.5? Or any other number > 1 will do the trick? Can you add some comments to the code? People usually hate this kind of „Bulgarian constant“ and I don’t blame them. :)
Cheers, O.K. > 13. 1. 2026 v 17:25, Shivam_Dubey <[email protected]>: > > ok so i can start working on this issue and try to find a tangible solution > and report to you > > On Tue, 13 Jan 2026 at 19:42, Aasim <[email protected] > <mailto:[email protected]>> wrote: >> A PR doesn't necessarily need a corresponding issue. You can just explain >> the fix made in the PR description above >> the release notes. >> >> On Tue, 13 Jan, 2026, 19:36 shuvro bhattacharjee, <[email protected] >> <mailto:[email protected]>> wrote: >>> To make a pull request should i create an issue first? Or i can directly >>> make PR without making any issue ? Because there is no issue created for >>> this error . >>> >>> Thank You >>> On Tuesday, January 13, 2026 at 4:44:00 AM UTC+6 Oscar wrote: >>>> Yes, that seems reasonable. >>>> >>>> On Mon, 12 Jan 2026 at 22:06, shuvro bhattacharjee >>>> <[email protected] <>> wrote: >>>> > >>>> > Hi Everyone, >>>> > >>>> > I wanted to share a fix for a test failure I encountered while running >>>> > the SymPy test suite on my machine. >>>> > >>>> > My Environment: >>>> > >>>> > OS: Windows 11 (64-bit) >>>> > >>>> > Python Version: 3.13.1 >>>> > >>>> > Module: sympy.codegen >>>> > >>>> > The Problem: >>>> > >>>> > When running the tests for Newton's Method algorithms, I hit a Failure >>>> > in test_newtons_method_function__rtol_cse_nan. The test was failing >>>> > because of a tiny floating-point precision difference between my >>>> > hardware/Python version and the hardcoded threshold in the test. >>>> > >>>> > Calculated Error: $2.86126... \times 10^{-15}$ >>>> > >>>> > Allowed Threshold: $2.64523... \times 10^{-15}$ >>>> > >>>> > Even though the difference was only $0.0000000000000002$, it was enough >>>> > to trigger an AssertionError. >>>> > >>>> > How I Solved It: >>>> > >>>> > I modified the test file located at: >>>> > >>>> > sympy\codegen\tests\test_algorithms.py >>>> > >>>> > At line 180, I adjusted the tolerance to be slightly more flexible. I >>>> > changed the assertion to allow for a small buffer: >>>> > >>>> > Original: assert abs(result - ref) < req >>>> > >>>> > Fixed: assert abs(result - ref) < req * 1.5 >>>> > >>>> > Verification: >>>> > >>>> > After applying the fix, I reran the test suite. The failure is gone, and >>>> > the module now passes 100% on my system! >>>> > >>>> > Final Test Output: >>>> > >>>> > Plaintext >>>> > sympy\codegen\tests\test_algorithms.py .ss.s. [100%] ================ 3 >>>> > passed, 3 skipped, 1 warning in 1.70s ================ >>>> > >>>> > This ensures the test suite is robust against the slight variations in >>>> > floating-point handling found in newer Python versions like 3.13. >>>> > >>>> > Can I make a PR for contributing on this issue? >>>> > >>>> > -- >>>> > You received this message because you are subscribed to the Google >>>> > Groups "sympy" group. >>>> > To unsubscribe from this group and stop receiving emails from it, send >>>> > an email to [email protected] <>. >>>> > To view this discussion visit >>>> > https://groups.google.com/d/msgid/sympy/caddf174-2549-4667-8ecf-e47e1235bc76n%40googlegroups.com. >>> >>> >>> -- >>> You received this message because you are subscribed to the Google Groups >>> "sympy" group. >>> To unsubscribe from this group and stop receiving emails from it, send an >>> email to [email protected] >>> <mailto:[email protected]>. >>> To view this discussion visit >>> https://groups.google.com/d/msgid/sympy/3eccd388-c45d-4e58-9fa6-4c067798f612n%40googlegroups.com >>> >>> <https://groups.google.com/d/msgid/sympy/3eccd388-c45d-4e58-9fa6-4c067798f612n%40googlegroups.com?utm_medium=email&utm_source=footer>. >> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "sympy" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected] >> <mailto:[email protected]>. >> To view this discussion visit >> https://groups.google.com/d/msgid/sympy/CAO0%2BxCVeHOq-5C2FmpHmdTEKDgHxvHZYdZ%2B6YOWW24Uxjd4iWA%40mail.gmail.com >> >> <https://groups.google.com/d/msgid/sympy/CAO0%2BxCVeHOq-5C2FmpHmdTEKDgHxvHZYdZ%2B6YOWW24Uxjd4iWA%40mail.gmail.com?utm_medium=email&utm_source=footer>. > > > -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected] > <mailto:[email protected]>. > To view this discussion visit > https://groups.google.com/d/msgid/sympy/CACuYkuEpd-uT2FocRiH16gPLyTjgDds4YZm%2ByUAmoPF6BdcDRA%40mail.gmail.com > > <https://groups.google.com/d/msgid/sympy/CACuYkuEpd-uT2FocRiH16gPLyTjgDds4YZm%2ByUAmoPF6BdcDRA%40mail.gmail.com?utm_medium=email&utm_source=footer>. -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion visit https://groups.google.com/d/msgid/sympy/2805A7FF-2F43-421F-A2BA-273B4508F1A4%40gmail.com.
