Hello sympy maintainers,
I was checking the TODOs inside the diffgeom module and found a 2 of them
which were already working
all I did was remove the comments on the asserts and just run the tests
def test_point():
point = Point(cs, [x, y])
assert point != Point(cs, [2, y])
#TODO assert point.subs(x, 2) == Point(cs, [2, y])
#TODO assert point.free_symbols == set([x, y])
were just changed to:
def test_point():
point = Point(cs, [x, y])
assert point != Point(cs, [2, y])
assert point.subs(x, 2) == Point(cs, [2, y])
assert point.free_symbols == set([x, y])
all tests passed, they worked on isympy as well (just to double check)
are these stale TODOs? shld I create a PR for them ??
or are they supposed to remain commented
Thanks, Ayush
--
You received this message because you are subscribed to the Google Groups
"sympy" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/sympy/c2747e7e-b346-40ba-a676-3a7af520ddd1n%40googlegroups.com.
