On Sun, 1 Feb 2026 at 13:44, Jason Moore <[email protected]> wrote: > > This reminds me that there is more nuance than I originally wrote. > > Github has 4 PR states and as far as I can gather from the last 15 years of > community practice this is how we've treated them: > > - Open (green): request for review and author desires to have it merged > - Closed (red): ether a core dev closed it to signal it will not be merged or > the submitter self-closes it to signal they will not pursue it further > - Merged (purple): a core dev merged the PR into master > - Draft (grey): pull request shared so others can view the work or > collaborate but not ready for review and/or merging (we used to use "WIP" in > the title, as this a relatively new GH feature)
No one has ever used these consistently and if we had a system for this then it would just generate more admin like manually marking someone's PR as draft or having to explain to people what the system is. The same problems happened with the "author's turn" labels. > I do think these have been distinct meanings and arose through many past > conversations and practices. At one point in the past, we even used labels to > designate "author's turn" or "reviewer's turn" to indicate who's > responsibility it is to take the next steps in moving a PR forward. The green > open PRs stall because we are waiting on one of these turns. This is why I think a 1 month reminder would be useful. It is a prompt to figure out whose turn it is. If all the reviewers overlooked it for 1 month then it is reasonable to be reminded of that. The 1 month reminder can also be a prompt for someone to say "I would like to review this and I think it is good but I just don't have the time to review it in full right now" which makes the situation clear to everyone (and resets the inactivity timer). On the other hand whether you use labels or whatever else I think a lot of contributors just don't understand that it is their turn and the 1 month reminder can have a message that prompts them to think about this like: - If someone has requested changes to the PR then they are probably waiting for you to make those changes. - If the CI checks have failed then reviewers are probably not going to bother commenting to say that changes are needed since they would expect that to be obvious. On the other hand if we have a 1 month reminder and then nothing happens in the next month then chances are high that the maintainers don't want it or the contributor is not willing or able to complete it. At that point leaving it open is usually just misleading. No one is likely coming back to it and if they do come back to it then it can be reopened to signal that change in status. -- Oscar -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion visit https://groups.google.com/d/msgid/sympy/CAHVvXxQ51nuVBch9WMbOrkJbhfGFjuP9%2BVXV_kv3_b3_SeJ5TA%40mail.gmail.com.
