Hi all, So far today 10 PRs have been closed (by Jason or by me) because the author removed the PR description template. It has always been the case that the release notes check would fail the PR if that part was removed but I think more needs to be enforced. In particular the current AI policy says that a PR should include an "AI Generation Disclosure" and that is part of the template. It is quite common that either just the AI part of the template is removed or that the whole template is removed.
I think we maybe need a bit of a rethink about how the template looks and what it says in the AI part. In the template it says: ``` #### AI Generation Disclosure <!-- If this pull request includes AI-generated code or text, please disclose the tool used and specify which lines were generated. Disclosure is not required for minor assistive tasks, such as spell-checking or code reviewing, in primarily human-authored work. Otherwise, leave this area blank. Read our Policy on AI Generated Code and Communication at https://docs.sympy.org/dev/contributing/ai-generated-code-policy.html. --> ``` The "leave this area blank" part now seems ambiguous to me given that many people just delete it. What we want here is a clear statement about how AI was used or not used. The reason that this is important is because if someone says "No code was written by AI" but the code is obviously written by AI then we can just close the PR for that reason. We need an explicit statement though so I don't think it is enough to let people leave the area blank but maybe the wording in the template does not make this obvious. More generally I think that the template is just too long so I am not surprised that in some cases people would just delete it or not notice what the important parts are. I also wonder if a lot of contributors just don't even see the template. My suspicion is that many people now open a PR by clicking an "open a PR" button (or an AI prompt?) in their editor meaning that they don't go to the actual GitHub website themselves and edit that text box directly. We probably need to have a bot that closes PRs if they don't match the template or maybe it could be just that sympy-bot checks more things since it seems most people seem to get the message about the release notes check from sympy-bot. -- Oscar -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion visit https://groups.google.com/d/msgid/sympy/CAHVvXxSsMFf06r0WN6mdhkb2%3DMBtrEV2xZ-DrN9h2F1H6wVEbw%40mail.gmail.com.
