Re: Patch for feature configuration in the ValidateMediator

[Hadrian Zbarcea]

Resubmitted patch attached.  I hope it's what you expected now.  I decided to keep the 2 boolean variables (and the set/get).  A private List properties would have done the job, but then I would have had to navigate the list at runtime to figure out the property values.  It would have been an unnecessary performance hit, so I preferred a bit of redundancy.

Please let me know if it's ok or it requires more tweaking.

Thanks
Hadrian

On 6/29/06, Hadrian Zbarcea < [EMAIL PROTECTED]> wrote:

I sure can :).  I will resubmit a patch shortly.

Thanks

Hadrian

On 6/29/06, Asankha C. Perera < [EMAIL PROTECTED] > wrote:

Hi Hadrian

Can you make changes to support setting any validation feature on/off as properties to the Validate mediator instead of as attributes? I think that would be a better way to approach this..?

i.e.
This
<validate schema="url" [source="xpath"]>
    <property name="schema-full-checking" value="true|false"/>
    <property name="honour-all-schemaLocations" value="true|false"/>
    ......
</validate>

Instead of..
<validate schema="url" [source="xpath"] [schema-full-checking="boolean"] [honour-all-schemaLocations="boolean"]>
    ......
</validate>

asankha



Hadrian Zbarcea wrote:

Hi,

Please find attached another patch that makes the ValidateMediator more configurable with respect to the validation features it uses.  In the current implementation both " http://apache.org/xml/features/validation/schema-full-checking" and "http://apache.org/xml/features/honour-all-schemaLocations" features are enabled (hardcoded) without posibility to disable them via configuration if so desired.

The patch solves the above problem and fixes some typos in the test.  I tested it with the Sun JDKs 1.4.2_06 and 1.5.0_06 on WinXP.

Thanks for taking the time and considering it.
Hadrian

---------------------------------------------------------------------To unsubscribe, e-mail: 

[EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

synapse-validate.patch
Description: Binary data

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]