They all seem like good improvements to me.
How about having the type attribute as optional when the key attribute is
used so that the language can still be automatically determined from the
script file extension but you can override that with the type attribute if
required? Also, what about naming the attribute 'language' instead of
'type'?
So you can have the language determined automatically with:
<script key="myscript" />
or define the language explicitly with:
<script key="myscript" language="javascript" />
...ant
On 2/22/07, Kasun Samarasinghe <[EMAIL PROTECTED]> wrote:
Hi
Currently Synapse supports two variants for script mediation, where the
script could be specified through a property or inline.
E.g.
<set-property name="prop" src="scriptfile.LL"/>
in mediation
<script key="prop" function="mediation_function"/>
In line mediators where we specify the script type in it self as LL
E.g.
<script.LL><![CDATA[
some script......
]]></script.LL>
I think these could be combined into one single script mediator. Also,
I think its better to explicitly specify the script language, as
guessing the language when the script is specified by a property may
not
always be reliable. So the suggestion is
E.g
<script type="LL" [key="prop"] [function="mediation_function"]>
<![CDATA[.. inline script ..]]>?
</script>
What do you think? I would be happy to raise a jira and submit a patch
for this enhancement
thanks
kasun
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
