On Wed, 2009-07-22 at 23:26 +0200, Frederik Himpe wrote:
> On Wed, 22 Jul 2009 21:05:04 +0000, Frederik Himpe wrote:
> 
> > librapi2 0.14's configure script does CFLAGS=`echo $CFLAGS | sed
> > 's|-Werror||'`
> > 
> > However, if you have set -Werror=format-security in your CFLAGS (which
> > is the default in Mandriva), this results in the broken option
> > "=format-security", breaking the configure script with: gcc:
> > =format-security: No such file or directory when building the pthread
> > tests.
> 
> Actually, in my opinion the configure script should not do such a change 
> to the CFLAGS. If the user breaks things because of his custom CFLAGS, he 
> should know how to fix it by removing the offending CFLAG or by 
> contributing patches to make the warnings/errors go away. Especially in 
> this case, librapi builds fine with -Werror=format-security, so there's no 
> need to remove it.
> 

Actually I think you'll find this is more common than you think.

In this case, the autoconf pthread checks blow up with -Werror in
CFLAGS, so it must be removed, and restored after this check. If you can
fix this I'm sure the autoconf guys will be delighted.

In the meantime, try replacing the sed with this one.

CFLAGS=`echo $CFLAGS | sed 's|-Werror[^[:space:]]*||'`

Mark

Attachment: signature.asc
Description: This is a digitally signed message part

------------------------------------------------------------------------------
_______________________________________________
SynCE-Devel mailing list
SynCE-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/synce-devel

Reply via email to