On Wed, 2011-01-26 at 16:39 +0100, David Eriksson wrote:
> On Wed, Jan 26, 2011 at 15:52, Mark Ellis <m...@mpellis.org.uk> wrote:
> > On Wed, 2011-01-26 at 13:12 +0100, Karl Relton wrote:
> >> The following patch fixes it!
> >>
> >> --- synce-device-manager.c.orig 2011-01-26 12:06:31.076751002 +0000
> >> +++ synce-device-manager.c 2011-01-26 12:07:15.360751014 +0000
> >> @@ -123,7 +123,7 @@
> >>
> >> GSList *device_entry_iter = priv->devices;
> >> while (device_entry_iter) {
> >> - if ((((DeviceEntry*)device_entry_iter->data)->server_990 = server) ||
> >> (((DeviceEntry*)device_entry_iter->data)->server_5679 = server))
> >> + if ((((DeviceEntry*)device_entry_iter->data)->server_990 == server)
> >> || (((DeviceEntry*)device_entry_iter->data)->server_5679 == server))
> >> break;
> >> device_entry_iter = g_slist_next(device_entry_iter);
> >> }
> >>
> >>
> >>
> >
> > You're an absolute legend !!!!!!
> >
> > Had to be something daft like that, it was too wierd not to be. Me hides
> > embarrassed grin :)
>
> Nice catch!
>
> Mark, doesn't this show with -Wall -Werror? :-)
>
> \DavidI thought the same thing, but I always build with that, so I tried it, nothing. I think it does if you don't protect it with parentheses. Of course I had protected it anyway :)
signature.asc
Description: This is a digitally signed message part
------------------------------------------------------------------------------ Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d
_______________________________________________ SynCE-Devel mailing list SynCE-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/synce-devel
