http://bugzilla.moblin.org/show_bug.cgi?id=6181
--- Comment #9 from pohly <[email protected]> 2009-09-22 23:17:43 --- (In reply to comment #8) > Patrick, maybe you can have a review now. Looks reasonable. I've merged it into master and the dbus-api branch. There's one minor detail which could be improved: the code which scans directories for backends is not exception-safe. It calls opendir() and later opendir(), but if an exception is thrown in-between (like out-of-memory), then the closedir() is skipped. In this case this is a minor problem, but because exceptions are used throughout SyncEvolution, normally code should be exception-safe. In this case the ReadDir helper class in SyncEvolutionUtil.h could be used. -- Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching someone on the CC list of the bug. _______________________________________________ Syncevolution-issues mailing list [email protected] http://lists.syncevolution.org/listinfo/syncevolution-issues
