http://bugzilla.moblin.org/show_bug.cgi?id=5049





--- Comment #8 from pohly <[email protected]>  2009-09-28 02:02:30 ---
(In reply to comment #7)
> Pushed to sqlite branch.

Comments:
* SyncSource::throwError() inserts "<source name>:" as prefix
  automatically, code like this thus doubles the prefix;
  getName() should not be used:
  throwError(string(getName())+ "contact not found: " + uid)
* SQLiteUtil::prepareSQL: should use StringPrintf (from SyncEvolutionUtil.)
  instead of vnsprintf
* --enable-sqlite: please keep the backend disabled by default.
  This is something that developers should explicitly ask for.

> One drawback is sqlite backend can not use client-test utilities, because it
> requires serialized access of contact data.

Correct. Hmm, can we use the Synthesis engine to create a serialized vFormat
for such backends? Just thinking aloud here, I have no idea how useful some of
the tests are when there is no truly native format.

-- 
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
_______________________________________________
Syncevolution-issues mailing list
[email protected]
http://lists.syncevolution.org/listinfo/syncevolution-issues

Reply via email to