http://bugzilla.moblin.org/show_bug.cgi?id=6668
pohly <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #5 from pohly <[email protected]> 2009-10-15 01:42:42 --- (In reply to comment #4) > (In reply to comment #3) > > Therefore I am thinking work it at our side. > I applied Lukas's commit to moblin synthesis repo against master branch. > Pushed to congwu branch, did a rudimentary test, it worked well. Merged. I had a look at why this didn't show up in our testing and found that comparison of the PHOTO comparison was turned off, with the comment in README.mobical that: 'PHOTO' is compressed by server but still be correct Yongsheng, with which PHOTO did you find that the server compresses the data? I don't see that happening at the moment with our test PHOTO in vcard30.vcf. When enabling the PHOTO comparison for Mobical, I find both the problem reported by Yanshuang (parser problem) and (with the fix for that) another one: the server appends "ENDVCARD" to the PHOTO data, I suppose because the Synthesis encoder omits an obligatory empty line. Therefore I think we should enable PHOTO comparison again and (if the problem is gone) remove the comment about PHOTO compression. Patch below: diff --git a/test/README.mobical b/test/README.mobical index 0736eb3..69c141a 100644 --- a/test/README.mobical +++ b/test/README.mobical @@ -76,7 +76,6 @@ vCard21 X-ANNIVERSARY, X-SPOUSE, X-EVOLUTION-BLOG-URL, X-EVOLUTION-VIDEO-URL, X-GROUPWISE, X-ICQ, X-YAHOO, X-ASSISTANT -- The parameter 'X-EVOLUTION-URI-SLOT'of properties like 'TEL' and 'EMAIL' is lost - -- 'PHOTO' is compressed by server but still be correct -- 'FN' is not reserved and is replaced by server's composition of 'N' -- 'NOTE' length is less than 4000 -- vcard must have one of 'tel', 'email', or 'url','addr', otherwise, this vcard will diff --git a/test/synccompare.pl b/test/synccompare.pl index f130bfc..d72615d 100644 --- a/test/synccompare.pl +++ b/test/synccompare.pl @@ -389,7 +389,7 @@ sub Normalize { } } if ($mobical) { - s/^(CALURI|CATEGORIES|FBURL|NICKNAME|X-MOZILLA-HTML|PHOTO|X-EVOLUTION-FILE-AS|X-ANNIVERSARY|X-ASSISTANT|X-EVOLUTION-BLOG-URL|X-EVOLUTION-VIDEO-URL|X-GROUPWISE|X-ICQ|X-MANAGER|X-SPOUSE|X-YAHOO|X-AIM)(;[^:;\n]*)*:.*\r?\n?//gm; + s/^(CALURI|CATEGORIES|FBURL|NICKNAME|X-MOZILLA-HTML|X-EVOLUTION-FILE-AS|X-ANNIVERSARY|X-ASSISTANT|X-EVOLUTION-BLOG-URL|X-EVOLUTION-VIDEO-URL|X-GROUPWISE|X-ICQ|X-MANAGER|X-SPOUSE|X-YAHOO|X-AIM)(;[^:;\n]*)*:.*\r?\n?//gm; # some workrounds here for mobical's bug s/^(FN|BDAY)(;[^:;\n]*)*:.*\r?\n?//gm; -- Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching someone on the CC list of the bug. _______________________________________________ Syncevolution-issues mailing list [email protected] http://lists.syncevolution.org/listinfo/syncevolution-issues
