http://bugzilla.moblin.org/show_bug.cgi?id=2416





--- Comment #5 from pohly <[email protected]>  2009-12-11 03:21:54 PST ---
We decided to got for a different approach: instead of checking the situation
while a sync session is active, abort syncing for those data sources where we
detect a problem.

A problem is only a "slow" sync when no slow sync was requested. In particular,
when a client asks for "(incremental) one-way from client/server" and the
server chooses "refresh from client/server", then this is considered a valid
fallback. Other mismatches (for example, refresh from client requested, refresh
from server done) are unlikely and not worth writing code for.

In a client, "the requested mode" is the one in the config (when the client
initiates the sync) or the one requested by the server via SAN (when the server
initiates the sync). Both is available via SyncConfig+config filters.

In a server, "the requested one" is the one requested by the client. Our own
configuration is only relevant when we initiated the sync, and even then the
user might have chosen a different mode intentionally on the client (not
possible with most clients, but who knows...). It might be possible to get the
requested mode in a pre-session script.

That script might also be the right place to influence whether the session
continues with that source enabled, in both cases.

(In reply to comment #3)
> Slow syncs are dangerous. We depend on the server to correctly match items and
> not mess up the data. Therefore I suggest the following improvement:
> 
> If there is no local data, then go ahead with the slow sync. If there was no
> local data because the user had deleted all items, then they will get re-added
> and he has to delete them again. At least no data is lost.

With the model suggested above, this becomes a decision that the user has to
make. The information will not be provided by SyncEvolution automatically, but
at least on the command line can be retrieved via --status.

> If there is local data, then the right solution is not obvious. A novice user
> might prefer to not be bothered, in which case we should go ahead with the 
> slow
> sync. An advanced user might want to be warned and given a choice of how to
> proceed.

Let's add a very clear warning and not at a config option, at least for now.

-- 
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
_______________________________________________
Syncevolution-issues mailing list
[email protected]
http://lists.syncevolution.org/listinfo/syncevolution-issues

Reply via email to