http://bugzilla.moblin.org/show_bug.cgi?id=5041
--- Comment #6 from pohly <[email protected]> 2010-03-17 00:09:12 PST --- (In reply to comment #4) > (In reply to comment #0) > > Usage of stdout and cout should be avoided. Currently the > > SyncEvolutionCmdline > > class is still told to write into cout by syncevolution.cpp. > > > > When compiling SyncEvolution .cpp code, any reference to stdout or cout > > should > > trigger a compiler error (redefine the symbols?!). Some with printf, puts, > > etc. > you mean all files in SyncEvolution core or just syncevolution.cpp? If yes, Did you mean to write more here? I mean primarily the SyncEvolution core. That's were most of the output is generated. > > Instead of cout, a custom stream which passes the data into our logging > > system > > with a suitable tag that reproduces the output verbatim on the console and > > logs > > it in the normal log should be used. > it's good for command line. what's the 'tag' for? I think I meant something like INFO/ERROR. Instead of inserting those into a character data stream, the data sent to the client for formatting should be similar to what our logging code gets. Then for "normal" output we need something that says "don't add any prefix". > to determine whether to > reproduce the output on the console or log it in the normal log, or both? Logging into the file would be done inside the engine, not at the recipient. > > Running commands must redirect stdout of the processes and ideally keep > > processing that output while the command runs (rules out simple system() > > calls). > I don't understand it. Redirect stdout of processes which are started by > syncevolution? Yes. This is required for example for "synccompare". We already do that for stderr. (In reply to comment #5) > > Instead of cout, a custom stream which passes the data into our logging > > system > > with a suitable tag that reproduces the output verbatim on the console and > > logs > > it in the normal log should be used. > what's the 'normal log' here? the current used logger in the top of loggers > stack? what if the normal log is to send log to stdout for we know the default > Logger outputs the log to stdout? The normal log is the syncevolution-log.html file. How to find that in the Loggers is a different question that I can't answer without looking at the code. -- Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug. You are watching someone on the CC list of the bug. _______________________________________________ Syncevolution-issues mailing list [email protected] http://lists.syncevolution.org/listinfo/syncevolution-issues
