http://bugzilla.moblin.org/show_bug.cgi?id=10475
--- Comment #6 from pohly <[email protected]> 2010-04-13 07:53:06 PST --- (In reply to comment #5) > > (In reply to comment #3) > > > I don't think it's suitable, maybe 'abort' is a more proper choice. > > > > No. It would be a bad password, but "abort" nevertheless is a valid > > password. > > > > Using the empty hash is unambiguous. The D-Bus server should treat it as > > "user > > didn't provide password, abort". > ok, that's reasonable. The code is ready on branch 'mb10475'. Please review > and > merge it. I don't agree with "if (response.empty())". If we ever add something besides "password" (doing that is the reason for using a hash in the first place!), then the check might be wrong (response non-empty, but doesn't contain "password"). You need do a find("password"), then check and use the result of that. -- Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching someone on the CC list of the bug. _______________________________________________ Syncevolution-issues mailing list [email protected] http://lists.syncevolution.org/listinfo/syncevolution-issues
