http://bugzilla.moblin.org/show_bug.cgi?id=10487


pohly <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED




--- Comment #6 from pohly <[email protected]>  2010-04-19 07:51:25 PST ---
Fixed:

commit 10bcfe281236b1941eaf92325e3c5e577c67c8f3
Author: Patrick Ohly <[email protected]>
Date:   Mon Apr 19 16:35:00 2010 +0200

    auto sync notifications: avoid extra "Dismiss" button (MB #10487)

    mutter-moblin automatically adds that button itself. Because it didn't
    recognize that we also add it ourselves, we ended up with two buttons
    called "Dismiss".

    The way to avoid this and having a "Dismiss" button in other environments
    is to use the ID "default" for our "Dismiss" button, then it'll be ignored
    by mutter-moblin.

diff --git a/src/syncevo-dbus-server.cpp b/src/syncevo-dbus-server.cpp
index c07853d..96c13dc 100644
--- a/src/syncevo-dbus-server.cpp
+++ b/src/syncevo-dbus-server.cpp
@@ -5757,7 +5757,10 @@ void AutoSyncManager::Notification::send(const char
*summary,
     //so disable it in case of no support of actions
     if(m_actions) {
         notify_notification_add_action(m_notification, "view", _("View"),
notifyAction, (gpointer)viewParams, NULL);
-        notify_notification_add_action(m_notification, "dismiss",
_("Dismiss"), notifyAction, (gpointer)viewParams, 
+        // Use "default" as ID because that is what mutter-moblin
+        // recognizes: it then skips the action instead of adding it
+        // in addition to its own "Dismiss" button (always added).
+        notify_notification_add_action(m_notification, "default",
_("Dismiss"), notifyAction, (gpointer)viewParams, 
     }
     notify_notification_show(m_notification, NULL);
 }

-- 
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
_______________________________________________
Syncevolution-issues mailing list
[email protected]
http://lists.syncevolution.org/listinfo/syncevolution-issues

Reply via email to