http://bugs.meego.com/show_bug.cgi?id=11044

pohly <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING FOR UPSTREAM        |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from pohly <[email protected]> 2010-12-20 02:42:15 PST ---
Root cause found and included in 1.1.1:

commit 31f90cff28d24a5f31579039597ccfc5a534288a
Author: Lukas Zeller <[email protected]>
Date:   Thu Dec 16 18:32:02 2010 +0100

    engine: server case: fixed bad bug that could mess up tempGUIDs. These must
be cleared when first <Sync> is recei

    Until now, the tempGUIDs were cleared only once when <Alert> was received.
    This is ok to create a clean starting point for loading previous session's
    tempGUIDs, which might be needed to resolve "early maps" also related to
    the previous session.

    However, as soon as the current session starts <Sync>ing, that is,
    exchanging new items, these temporary IDs become invalid and
    fTempGUIDMap must be cleared once again.

    The missing cleanup has led to collisions in the tempGUID name space,
    because the tempGUIDs are created based on the fact that the list
    is empty at the beginning of <Sync>. As it could have entries
    from (possibly much!) earlier sessions, all sort of weird things
    could and did happen.

    Thanks Patrick for the extensive investigation of this!

commit d68c46d02710c19e4db2c854966aec972542a2a9
Author: Patrick Ohly <[email protected]>
Date:   Sun Dec 19 22:43:51 2010 +0100

    temporary ID mapping: flag unexpected state as real errors

    As explained by Lukas in the "[os-libsynthesis] temporary UID mapping"
    mail thread, the code which catches ID conflicts just works around
    symptoms. The code should never be triggered.

    This patch thus turns the messages into errors. Lukas' patch will fix
    the real issue. Keeping the code is still useful to have a fallback,
    just in case. At least for a while: the duplicate check is costly and
    should be removed once the fix has been verified sufficiently.

-- 
Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
_______________________________________________
Syncevolution-issues mailing list
[email protected]
http://lists.syncevolution.org/listinfo/syncevolution-issues

Reply via email to