http://bugs.meego.com/show_bug.cgi?id=5819
pohly <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |FIXED --- Comment #11 from pohly <[email protected]> 2011-01-03 00:17:55 PST --- (In reply to comment #10) > (In reply to comment #9) > > (In reply to comment #8) > > > If one task has been put in the task list, then then setting autoSync=0 > > > won't > > > disable it. But there is no future task added in the list. > > Perhaps this is what I was seeing. I'll check again. > > I still don't get why you think that my patch fixes the original problem. > > Can > > you explain this to me? > 1) The patch firstly checks whether the command line will change the > config(see > Cmdline.cpp) > 2) It gets the result to show whether the command line changes the config(via > configWasModified) and set 'm_setConfig' > 3) Once the current session is done, then it invokes auto sync manager to > remove the task related to the current config and re-load the changed config > and add the auto sync task if needed (see AutoSyncManager::update(const > string& > configName). Are we talking about the same patch? 1b243b7b8356a27b0c7872cd20649ac29147d282 does not call AutoSyncManager::update(). After reviewing the code I now understand why 1b243b7b fixes this issue: - AutoSyncManager::update() has been called if m_configSet was true for a while. - m_configSet was not set for command line sessions (causing this issue here). - 1b243b7b fixes that by introducing m_setConfig = m_cmdline->configWasModified() That last change was motivated by the need to have ConfigChanged signals also for command line session; I wasn't aware that I fixed some other issue as well ;-} I can no longer reproduce the issue, so now I am okay with closing it. -- Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching someone on the CC list of the bug. _______________________________________________ Syncevolution-issues mailing list [email protected] http://lists.syncevolution.org/listinfo/syncevolution-issues
