https://bugs.freedesktop.org/show_bug.cgi?id=85239
--- Comment #5 from Patrick Ohly <[email protected]> --- Comment on attachment 108598 --> https://bugs.freedesktop.org/attachment.cgi?id=108598 Patch to improve logging problems with all day event times Review of attachment 108598: ----------------------------------------------------------------- A better formatting of the commit message would be a short summary line followed by an empty line, then full description. g_warning("All day event with no timezone does not start at UTC midnight: %s", icaltime_as_ical_string_r(tt)); This leaks the string, because the _r variant returns the newly allocated string and expects the caller to free it. The other locations with the normal version are okay because libical then retains ownership in a ring buffer. Can you fix that in a future patch? For now I'll take the patch as-is because I cannot test it myself and don't want to break something that you already tested successfully. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.
_______________________________________________ Syncevolution-issues mailing list [email protected] https://lists.syncevolution.org/mailman/listinfo/syncevolution-issues
