On Tue, 2009-06-23 at 06:03 -0700, Patrick Ohly wrote: > On Tue, 2009-06-23 at 05:23 -0700, Jussi Kukkonen wrote: > > Patrick Ohly wrote: > > I have to say my git-fu or shell script skills aren't good enough to say > > if import-synthesis-xml.sh is going to work reliably or not but I guess > > that's not really crucial: eyeballing the results will let us now. This > > bit did look odd: > > > > > revisions="`git log -n 1 $TARGET | tail -1`..master" > > > > I don't think that will work. > > Because of the `` embedded inside a string? That's fine, the shell > expands it and concatenates the result.
While I was away this afternoon (appointment), Jussi explained via chat that the line "will give me the last line in the description of $TARGET" - but that's exactly what it should do, because that line contains the original Synthesis commit ID. So my comments might have been a bit terse, but I think the script works - at least it did when I tested it ;-) Therefore I went ahead and pushed this change. From now on, please update the syncclient_sample_config.xml instead of syncevolution.xml. -- Best Regards, Patrick Ohly The content of this message is my personal opinion only and although I am an employee of Intel, the statements I make here in no way represent Intel's position on the issue, nor am I authorized to speak on behalf of Intel on this matter. _______________________________________________ SyncEvolution mailing list SyncEvolution@moblin.org https://lists.moblin.org/mailman/listinfo/syncevolution
